dsmiley commented on code in PR #4202:
URL: https://github.com/apache/solr/pull/4202#discussion_r2909362543
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -3143,4 +3151,40 @@ private static void ensureRegisteredSearcher(SolrCore
core) throws InterruptedEx
}
}
}
+
+ /** Creates the .system collection if it doesn't exist. Returns true iff
this created it. */
+ public boolean createSystemColl() throws Exception {
Review Comment:
moved from HttpSolrCall to a more suitable place as the same logic now has 2
callers
##########
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##########
@@ -658,6 +633,13 @@ void createCollection(
}
protected CloudSolrClient cloudClient() {
+ // create the system collection if it doesn't exist
Review Comment:
doing this here means pretty minimal change to this class
##########
solr/core/src/test/org/apache/solr/handler/designer/TestSchemaDesignerConfigSetHelper.java:
##########
@@ -60,9 +59,6 @@ public static void createCluster() throws Exception {
configureCluster(1)
.addConfig(DEFAULT_CONFIGSET_NAME, new
File(ExternalPaths.DEFAULT_CONFIGSET).toPath())
.configure();
- // SchemaDesignerConfigSetHelper depends on the blob store
Review Comment:
yay; it's tested now.
##########
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##########
@@ -521,29 +519,6 @@ protected void postDataToBlobStore(CloudSolrClient
cloudClient, String blobName,
}
}
- private String getBaseUrl(final String collection) {
Review Comment:
unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
