dsmiley commented on code in PR #4225:
URL: https://github.com/apache/solr/pull/4225#discussion_r2972413761
##########
solr/test-framework/src/java/org/apache/solr/util/ExternalPaths.java:
##########
@@ -83,7 +83,7 @@ static Path determineSourceHome() {
}
Path base = file.toAbsolutePath();
- while (!Files.exists(base.resolve("solr/test-framework/build.gradle"))
&& null != base) {
+ while (null != base &&
!Files.exists(base.resolve("solr/test-framework/build.gradle"))) {
Review Comment:
Copilot is right!
And furthermore, SolrTestCase references these constants in a way that will
also NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
