dsmiley commented on code in PR #4237:
URL: https://github.com/apache/solr/pull/4237#discussion_r3012383851
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedQueryComponentOptimizationTest.java:
##########
@@ -707,6 +711,55 @@ private QueryResponse queryWithAsserts(String... q) throws
Exception {
return response;
}
+ /**
+ * When a node resolves collection state for a collection it doesn't host,
queries should use
+ * cached state and not make ZK calls on every query.
+ */
+ @Test
+ public void testDistributedQueryDoesNotReadFromZk() throws Exception {
Review Comment:
aaaaah! Aha! You have fixed SOLR-15352 then; wonderful. I'm so glad I
hoped / suggested a test... we can learn a lot in the process.
Yes the changelog should reflect the scope of the problem, which apparently
isn't all queries. This explains why this problem hasn't been identified yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
