tomaszpolachowski commented on code in PR #826:
URL: https://github.com/apache/solr-operator/pull/826#discussion_r3013325451


##########
controllers/util/solr_util.go:
##########
@@ -377,6 +377,10 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, 
solrCloudStatus *solr.SolrCl
                        Name:  "SOLR_HOST",

Review Comment:
   It's for backward compatibility only. Depends if support for versions before 
introducing `solr.host.advertise` is necessary. If not then along with removal 
some tests and `probeCommand` in solr_security_util.go would require update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to