dsmiley commented on code in PR #4263:
URL: https://github.com/apache/solr/pull/4263#discussion_r3040969393
##########
solr/core/src/java/org/apache/solr/update/processor/ContentHashVersionProcessor.java:
##########
@@ -0,0 +1,196 @@
+package org.apache.solr.update.processor;
+
+import org.apache.lucene.util.BytesRef;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.SolrInputDocument;
+import org.apache.solr.core.SolrCore;
+import org.apache.solr.handler.component.RealTimeGetComponent;
+import org.apache.solr.handler.component.RealTimeGetComponent.Resolution;
+import org.apache.solr.request.SolrQueryRequest;
+import org.apache.solr.response.SolrQueryResponse;
+import org.apache.solr.schema.SchemaField;
+import org.apache.solr.schema.TextField;
+import org.apache.solr.update.AddUpdateCommand;
+import org.apache.solr.update.UpdateCommand;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.lang.invoke.MethodHandles;
+import java.util.Base64;
+import java.util.Collection;
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+import java.util.function.Predicate;
+
+/**
+ * An implementation of {@link UpdateRequestProcessor} which computes a hash
of selected doc values, and uses this hash
Review Comment:
Yes, "field values".
This PR *Is* using Lucene docValues, but it's not plainly clear to
non-Lucene/Solr experts.
`org.apache.solr.handler.component.RealTimeGetComponent#getInputDocument`
fetches the document from the updateLog or the index -- and if it does fetch it
from the index, the values will come from
`org.apache.solr.search.SolrDocumentFetcher` that will in turn fetch it from
DocValues if `docValues=true` in the schema. SDF javadocs say so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
