janhoy commented on code in PR #4267:
URL: https://github.com/apache/solr/pull/4267#discussion_r3044910405
##########
solr/packaging/test/test_zk.bats:
##########
@@ -48,15 +48,18 @@ teardown() {
@test "long help" {
run solr zk -h
- assert_output --partial "bin/solr zk ls"
- assert_output --partial "bin/solr zk updateacls"
+ # TODO: Long help is different in picocli
+ #assert_output --partial "bin/solr zk ls"
+ #assert_output --partial "bin/solr zk updateacls"
assert_output --partial "Pass --help or -h after any COMMAND"
+ assert_output --partial "updateacls"
}
-@test "running subcommands with zk is prevented" {
- run solr ls / -z localhost:${ZK_PORT}
- assert_output --partial "You must invoke this subcommand using the zk command"
-}
+# TODO: Picocli fails in a different way when a subcommand is not invoked
using the zk command
+#@test "running subcommands with zk is prevented" {
+# run solr ls / -z localhost:${ZK_PORT}
+# assert_output --partial "You must invoke this subcommand using the zk
command"
+#}
Review Comment:
Letting this sit here as a reminder to change assertions to picocli-only
after we remove commons-cli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
