karlderkaefer commented on code in PR #811:
URL: https://github.com/apache/solr-operator/pull/811#discussion_r3051012657
##########
helm/solr/templates/solrcloud.yaml:
##########
@@ -146,6 +146,9 @@ spec:
{{- if .Values.dataStorage.persistent.pvc.storageClassName }}
storageClassName: {{
.Values.dataStorage.persistent.pvc.storageClassName | quote }}
{{- end }}
+ {{- if .Values.dataStorage.persistent.pvc.volumeAttributesClassName
}}
+ volumeAttributesClassName: {{
.Values.dataStorage.persistent.pvc.volumeAttributesClassName | quote }}
+ {{- end }}
Review Comment:
what copilot is complaining about is that the condition is not added to line
131
https://github.com/coolstim/solr-operator/blob/753ee4ac69eb5638ea3e85e2f63c1fa097b0f467/helm/solr/templates/solrcloud.yaml#L139
however the capacity is always set to `20Gi` by default. I don't believe
this is valid edge case where capacity is set to empty. however to make copilot
you could add to line 131
```
{{- if (or .Values.dataStorage.capacity
.Values.dataStorage.persistent.pvc.storageClassName
.Values.dataStorage.persistent.pvc.volumeAttributesClassName) }}
``` but not required since capacity should be always set
##########
helm/solr/templates/solrcloud.yaml:
##########
@@ -146,6 +146,9 @@ spec:
{{- if .Values.dataStorage.persistent.pvc.storageClassName }}
storageClassName: {{
.Values.dataStorage.persistent.pvc.storageClassName | quote }}
{{- end }}
+ {{- if .Values.dataStorage.persistent.pvc.volumeAttributesClassName
}}
+ volumeAttributesClassName: {{
.Values.dataStorage.persistent.pvc.volumeAttributesClassName | quote }}
+ {{- end }}
Review Comment:
what copilot is complaining about is that the condition is not added to line
131
https://github.com/coolstim/solr-operator/blob/753ee4ac69eb5638ea3e85e2f63c1fa097b0f467/helm/solr/templates/solrcloud.yaml#L139
however the capacity is always set to `20Gi` by default. I don't believe
this is valid edge case where capacity is set to empty. however to make copilot
you could add to line 131
```
{{- if (or .Values.dataStorage.capacity
.Values.dataStorage.persistent.pvc.storageClassName
.Values.dataStorage.persistent.pvc.volumeAttributesClassName) }}
```
but not required since capacity should be always set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
