epugh commented on code in PR #4264:
URL: https://github.com/apache/solr/pull/4264#discussion_r3068077906
##########
solr/api/src/java/org/apache/solr/client/api/endpoint/ConfigsetsApi.java:
##########
@@ -71,6 +79,46 @@ SolrJerseyResponse
deleteConfigSet(@PathParam("configSetName") String configSetN
throws Exception;
}
+ /**
+ * V2 API definition for downloading an existing configset as a ZIP archive.
+ *
+ * <p>Equivalent to GET /api/configsets/{configSetName}/download
+ */
+ @Path("/configsets/{configSetName}")
+ interface Download {
+ @GET
+ @Path("/download")
+ @Operation(
+ summary = "Download a configset as a ZIP archive.",
+ tags = {"configsets"},
+ extensions = {
+ @Extension(properties = {@ExtensionProperty(name =
RAW_OUTPUT_PROPERTY, value = "true")})
+ })
+ @Produces("application/zip")
+ Response downloadConfigSet(
+ @PathParam("configSetName") String configSetName,
+ @QueryParam("displayName") String displayName)
+ throws Exception;
+ }
+
+ /**
+ * V2 API definition for reading a single file from an existing configset.
+ *
+ * <p>Equivalent to GET /api/configsets/{configSetName}/file?path=...
+ */
+ @Path("/configsets/{configSetName}")
+ interface GetFile {
+ @GET
+ @Path("/file")
+ @Produces(MediaType.TEXT_PLAIN)
+ @Operation(
+ summary = "Get the contents of a file in a configset.",
+ tags = {"configsets"})
+ ConfigSetFileContentsResponse getConfigSetFile(
Review Comment:
wow, this ia a damn good question, that looked simple and then got more
complex. Yeah, what if you store a model object that is binary? Or an image?
I could imagine that in the near future we will have more binary objects that
are part of a configset, and that you might put and get individually... for
example, some of the NLP stuff has small binary objects that might be in your
configset...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
