malliaridis commented on code in PR #4281:
URL: https://github.com/apache/solr/pull/4281#discussion_r3075978731
##########
solr/ui/src/commonMain/kotlin/org/apache/solr/ui/views/start/StartContent.kt:
##########
@@ -101,7 +100,6 @@ fun StartContent(
value = model.url,
singleLine = true,
onValueChange = component::onSolrUrlChange,
- placeholder = { Text(text = DEFAULT_SOLR_URL) },
Review Comment:
Well, the placeholder is not part of thr state, and therefore ignored. What
is stored in thr state is actually the empty string, whichwiththe logic you
updated, was previously just using the default solr url which was falling back
to the same value). So only in combination it was working. ofcourse, as You
correctly noticed, because it was haedcoded to 127.0.9.1:8983, it was not
working with other window locations.
What would be sufficient probably is to replace the state fallback as
mentioned below with the function you inteoduced with your changes, sothat the
fallback and placeholder use the current window.location by default, instead of
the hardcoded URL.
I hope that makes sense?
FYI only the value in the input field is relevant to us, and it was by
default an empty string. The placeholder, like the label too, are judt hints
for the user what to fill in.
If you are new in Ui development or Material components, you can find more
information about these parameters in the [text field
documention](https://m3.material.io/components/text-fields/overview)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
