dsmiley commented on code in PR #4206: URL: https://github.com/apache/solr/pull/4206#discussion_r3084008571
########## solr/core/src/java/org/apache/solr/search/join/FiltersQParser.java: ########## Review Comment: @mkhludnev I found that FiltersQParser to be excessively factored/abstracted (each time I see the subclasses over the years I'm in for a puzzle of indirection). So I removed 2 methods that would be most helpful to remove: wrapSubordinateClause and noClausesQuery. Only one was overridden, and I wanted to use the opportunity to choose a different name anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
