malliaridis commented on code in PR #4283: URL: https://github.com/apache/solr/pull/4283#discussion_r3086580893
########## solr/ui/src/commonMain/composeResources/drawable/other_admission.xml: ########## Review Comment: These are SVG symbols from [Material Symbols](https://fonts.google.com/icons) that replace the library which previously was providing these and is not updated anymore. See [Implicit dependency on material-icons-core removed](https://kotlinlang.org/docs/multiplatform/whats-new-compose-180.html#implicit-dependency-on-material-icons-core-removed) for more information. The XML format comes from Android and grants maximum compatibility. See [Compose Multiplatform Resources Usage / Images](https://kotlinlang.org/docs/multiplatform/compose-multiplatform-resources-usage.html#images) for more details. Alternatively, we would have to include the SVG assets like [demonstrated here](https://kotlinlang.org/docs/multiplatform/compose-multiplatform-resources-usage.html#generated-maps-for-resources-and-string-ids:~:text=On%20every%20platform%20except%20Android%2C%20you%20can%20also%20turn%20an%20SVG%20file%20into%20a%20Painter%20object%3A). So I chose the XML format instead. ########## solr/ui/src/commonMain/composeResources/drawable/solr-logo-dark.svg: ########## Review Comment: They have only been formatted, hence why they look the same. I was considering not touching them, because with a proper linting they might be formatted anyway again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
