[ 
https://issues.apache.org/jira/browse/SOLR-18195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18074945#comment-18074945
 ] 

Chris M. Hostetter commented on SOLR-18195:
-------------------------------------------

{{CombinedQuerySolrCloudTest.testQueriesWithFacetAndHighlightsCollapse}} has 
started failing in ~36% of all jenkins builds in the past 7 days ... which 
seems suspiciously timed with this jira?

It looks like there is probably a "test method ordering" / "lack of cleanup by 
the test methods" issue, because this method specific reproduce line from 
jenkins seems to pass reliably on my machine...

{noformat}
gradlew test --tests 
CombinedQuerySolrCloudTest.testQueriesWithFacetAndHighlightsCollapse 
-Dtests.seed=75A3A0E11F683B2C -Dtests.multiplier=2 -Dtests.locale=bho 
-Dtests.timezone=Antarctica/Syowa -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
{noformat}

 ...but if i run the whole testclass with that seed the jenkins assertion 
failures reproduces reliably for me...

{noformat}
./gradlew test --tests CombinedQuerySolrCloudTest -Dtests.seed=75A3A0E11F683B2C 
-Dtests.multiplier=2 -Dtests.locale=bho -Dtests.timezone=Antarctica/Syowa 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
...
   >     java.lang.AssertionError: .response[0][id][0]:1!10!=2!2
   >         at 
__randomizedtesting.SeedInfo.seed([75A3A0E11F683B2C:7E860A8E0497562E]:0)
   >         at org.junit.Assert.fail(Assert.java:89)
   >         at 
org.apache.solr.BaseDistributedSearchTestCase.compareSolrResponses(BaseDistributedSearchTestCase.java:975)
   >         at 
org.apache.solr.BaseDistributedSearchTestCase.compareResponses(BaseDistributedSearchTestCase.java:1005)
   >         at 
org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:642)
   >         at 
org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:621)
   >         at 
org.apache.solr.BaseDistributedSearchTestCase.query(BaseDistributedSearchTestCase.java:609)
   >         at 
org.apache.solr.handler.component.CombinedQuerySolrCloudTest.testQueriesWithFacetAndHighlightsCollapse(CombinedQuerySolrCloudTest.java:321)

{noformat}

 

> Support for Collapse Results in Combined Query Component
> --------------------------------------------------------
>
>                 Key: SOLR-18195
>                 URL: https://issues.apache.org/jira/browse/SOLR-18195
>             Project: Solr
>          Issue Type: Improvement
>          Components: vector-search
>            Reporter: Sonu Sharma
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> With reference to previous new Query Component Feature:  
> https://issues.apache.org/jira/browse/SOLR-17319
> When using \{!collapse} with CombinedQueryComponent (hybrid search / RRF), 
> duplicate documents appear in the result set for the same collapse field 
> value. Each sub-query independently collapses correctly via 
> CollapsingPostFilter, but simpleCombine() merges results by Lucene doc ID 
> only - it has no awareness of the collapse field. Different sub-queries may 
> select different group heads for the same field value, and both survive the 
> merge.
> However it is well know limitation that :[ "In order to use these features 
> with SolrCloud, the documents must be located on the same 
> shard."|https://solr.apache.org/guide/solr/latest/query-guide/collapse-and-expand-results.html]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to