gerlowskija commented on PR #3991: URL: https://github.com/apache/solr/pull/3991#issuecomment-4289460463
Hey all - I wanted to incorporate some of the advice that @igiguere gave above. Particularly around giving AdminHandlerProxy a type parameter that allows its methods to be a bit more tailored to the particular use-case. I think it worked out really nicely! Slight bad news though - I wanted a fresh start as I was doing this and ultimately ended up using a new branch and force-pushing that here. Which will mangle some of the PR history and conversation-threads. Sorry about that - I should've found a better way. In any case, I'll update the PR description above to better reflect the latest design. And I'm taking this out of "Draft" mode for now and will aim to merge later this week. Tests and check both pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
