Copilot commented on code in PR #4305: URL: https://github.com/apache/solr/pull/4305#discussion_r3120778335
########## changelog/unreleased/update-dropwizard-metrics-4.2.33.yml: ########## @@ -0,0 +1,7 @@ +title: Update dropwizard.metrics to v4.2.33 +type: dependency_update +authors: +- name: Jan Høydahl +links: +- name: PR#4093 Review Comment: The changelog link text and URL refer to different PR numbers (`PR#4093` vs `/pull/4305`). Update either the `name` or the `url` so they match the actual PR for this change. ```suggestion - name: PR#4305 ``` ########## changelog/unreleased/PR#3757-update-org-eclipse-jgit-org-eclipse-jgit.yml: ########## @@ -0,0 +1,7 @@ +title: Update org.eclipse.jgit:org.eclipse.jgit to v7.5.0.202512021534-r Review Comment: This changelog entry says JGit was updated to `v7.5.0.202512021534-r`, but `gradle/libs.versions.toml` in this PR sets `eclipse-jgit` to `7.6.0.202603022253-r`. To avoid a misleading release note, update the changelog title to the effective version being shipped (or adjust the version catalog if the changelog is correct). ```suggestion title: Update org.eclipse.jgit:org.eclipse.jgit to v7.6.0.202603022253-r ``` ########## changelog/unreleased/PR#3105-update-org-checkerframework-checker-qual.yml: ########## @@ -0,0 +1,7 @@ +title: Update org.checkerframework:checker-qual to v3.53.1 Review Comment: This changelog entry states checker-qual `v3.53.1`, but this PR adds `solr/licenses/checker-qual-3.54.0.jar.sha1` and sets `checkerframework = \"3.54.0\"` in the version catalog. Update the changelog title to match the effective version being shipped. ```suggestion title: Update org.checkerframework:checker-qual to v3.54.0 ``` ########## gradle/libs.versions.toml: ########## @@ -135,52 +135,52 @@ javacc = "7.0.13" jaxb = "2.3.9" jayway-jsonpath = "2.9.0" jctools = "4.0.5" -jersey = "3.1.11" +jersey = "4.0.2" # @keep for version alignment jetbrains-annotations = "26.0.2" # @keep for version alignment jna = "5.18.1" # @keep for version alignment joda-time = "2.14.0" junit = "4.13.2" -junit-jupiter = "5.13.4" +junit-jupiter = "6.0.3" kotlin = "2.2.0" # @keep for version alignment kotlinx-atomicfu = "0.29.0" # @keep for version alignment kotlinx-browser = "0.3" -kotlinx-coroutines = "1.10.1" -kotlinx-datetime = "0.7.1" +kotlinx-coroutines = "1.10.2" +kotlinx-datetime = "0.7.1-0.6.x-compat" kotlinx-serialization = "1.9.0" # @keep used by spotless ktlint = "1.7.1" ktor = "3.2.2" langchain4j-bom = "1.9.1" # @keep Link checker version used in ref-guide link-checker = "1.4.2" -littlerobots-versioncatalogupdate = "0.8.5" +littlerobots-versioncatalogupdate = "1.1.0" lmax-disruptor = "4.0.0" logchange = "1.19.13" -ltgt-errorprone = "3.1.0" -mockito = "5.19.0" +ltgt-errorprone = "5.1.0" +mockito = "5.23.0" morethan-jmhreport = "0.9.6" mvikotlin = "4.3.0" navsecurity = "0.5.10" -netty = "4.2.6.Final" +netty = "4.2.12.Final" # @keep for version alignment -netty-tcnative = "2.0.66.Final" +netty-tcnative = "2.0.75.Final" nimbusds-josejwt = "10.5" nlopez-compose = "0.4.27" nodegradle-node = "7.1.0" # @keep Node JS version used in node.gradle (LTS) nodejs = "22.18.0" onnx = "1.23.0" Review Comment: This PR updates the locked/test dependency `com.microsoft.onnxruntime` to `1.24.3` (and adds the corresponding `solr/licenses/onnxruntime-1.24.3.jar.sha1`), but the version catalog still lists `onnx = \"1.23.0\"`. Align the catalog with the effective ONNX Runtime version to avoid future lockfile churn or accidental downgrades. ```suggestion onnx = "1.24.3" ``` ########## solr/core/gradle.lockfile: ########## @@ -122,56 +126,59 @@ org.apache.lucene:lucene-spatial-extras:10.4.0=compileClasspath,jarValidation,ru org.apache.lucene:lucene-spatial3d:10.4.0=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath org.apache.lucene:lucene-suggest:10.4.0=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath org.apache.lucene:lucene-test-framework:10.4.0=jarValidation,testCompileClasspath,testRuntimeClasspath -org.apache.opennlp:opennlp-dl:2.5.6=jarValidation,testRuntimeClasspath -org.apache.opennlp:opennlp-tools:2.5.6=jarValidation,testRuntimeClasspath +org.apache.opennlp:opennlp-dl:2.5.8=jarValidation,testRuntimeClasspath +org.apache.opennlp:opennlp-tools:2.5.8=jarValidation,testRuntimeClasspath org.apache.zookeeper:zookeeper-jute:3.9.4=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath org.apache.zookeeper:zookeeper:3.9.4=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath org.apiguardian:apiguardian-api:1.1.2=jarValidation,testCompileClasspath,testRuntimeClasspath org.carrot2:morfologik-fsa:2.1.9=jarValidation,testRuntimeClasspath org.carrot2:morfologik-polish:2.1.9=jarValidation,testRuntimeClasspath org.carrot2:morfologik-stemming:2.1.9=jarValidation,testRuntimeClasspath org.codehaus.woodstox:stax2-api:4.2.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty.ee10:jetty-ee10-servlet:12.0.27=jarValidation,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty.http2:jetty-http2-client-transport:12.0.27=apiHelper,jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath -org.eclipse.jetty.http2:jetty-http2-client:12.0.27=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty.http2:jetty-http2-common:12.0.27=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty.http2:jetty-http2-hpack:12.0.27=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty.http2:jetty-http2-server:12.0.27=jarValidation,testRuntimeClasspath -org.eclipse.jetty:jetty-alpn-client:12.0.27=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty:jetty-alpn-java-client:12.0.27=apiHelper,jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath -org.eclipse.jetty:jetty-alpn-java-server:12.0.27=jarValidation,testRuntimeClasspath -org.eclipse.jetty:jetty-alpn-server:12.0.27=jarValidation,testRuntimeClasspath -org.eclipse.jetty:jetty-client:12.0.27=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty:jetty-http:12.0.27=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty:jetty-io:12.0.27=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty:jetty-rewrite:12.0.27=jarValidation,testRuntimeClasspath -org.eclipse.jetty:jetty-security:12.0.27=jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty:jetty-server:12.0.27=jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty:jetty-session:12.0.27=jarValidation,testCompileClasspath,testRuntimeClasspath -org.eclipse.jetty:jetty-util:12.0.27=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.hk2.external:aopalliance-repackaged:3.1.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.hk2:hk2-api:3.1.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.hk2:hk2-locator:3.1.1=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath -org.glassfish.hk2:hk2-utils:3.1.1=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.hk2:osgi-resource-locator:1.0.3=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.jersey.containers:jersey-container-jetty-http:3.1.11=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath -org.glassfish.jersey.core:jersey-client:3.1.11=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.jersey.core:jersey-common:3.1.11=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.jersey.core:jersey-server:3.1.11=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.jersey.ext:jersey-entity-filtering:3.1.11=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.jersey.inject:jersey-hk2:3.1.11=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath -org.glassfish.jersey.media:jersey-media-json-jackson:3.1.11=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath -org.glassfish.jersey:jersey-bom:3.1.11=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty.ee10:jetty-ee10-servlet:12.0.34=jarValidation,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty.http2:jetty-http2-client-transport:12.0.34=apiHelper,jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath +org.eclipse.jetty.http2:jetty-http2-client:12.0.34=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty.http2:jetty-http2-common:12.0.34=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty.http2:jetty-http2-hpack:12.0.34=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty.http2:jetty-http2-server:12.0.34=jarValidation,testRuntimeClasspath +org.eclipse.jetty:jetty-alpn-client:12.0.34=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty:jetty-alpn-java-client:12.0.34=apiHelper,jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath +org.eclipse.jetty:jetty-alpn-java-server:12.0.34=jarValidation,testRuntimeClasspath +org.eclipse.jetty:jetty-alpn-server:12.0.34=jarValidation,testRuntimeClasspath +org.eclipse.jetty:jetty-client:12.0.34=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty:jetty-http:12.0.34=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty:jetty-io:12.0.34=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty:jetty-rewrite:12.0.34=jarValidation,testRuntimeClasspath +org.eclipse.jetty:jetty-security:12.0.34=jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty:jetty-server:12.0.34=jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty:jetty-session:12.0.34=jarValidation,testCompileClasspath,testRuntimeClasspath +org.eclipse.jetty:jetty-util:12.0.34=apiHelper,compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.glassfish.hk2.external:aopalliance-repackaged:3.1.1=compileClasspath,jarValidation,runtimeClasspath,testCompileClasspath,testRuntimeClasspath +org.glassfish.hk2.external:aopalliance-repackaged:4.0.0-M3=runtimeLibs +org.glassfish.hk2:hk2-api:3.1.1=compileClasspath,jarValidation,runtimeClasspath,testCompileClasspath,testRuntimeClasspath +org.glassfish.hk2:hk2-api:4.0.0-M3=runtimeLibs +org.glassfish.hk2:hk2-locator:4.0.0-M3=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath +org.glassfish.hk2:hk2-utils:3.1.1=compileClasspath,jarValidation,runtimeClasspath,testCompileClasspath,testRuntimeClasspath +org.glassfish.hk2:hk2-utils:4.0.0-M3=runtimeLibs +org.glassfish.hk2:osgi-resource-locator:3.0.0=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.glassfish.jersey.containers:jersey-container-jetty-http:4.0.2=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath +org.glassfish.jersey.core:jersey-client:4.0.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.glassfish.jersey.core:jersey-common:4.0.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.glassfish.jersey.core:jersey-server:4.0.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.glassfish.jersey.ext:jersey-entity-filtering:4.0.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.glassfish.jersey.inject:jersey-hk2:4.0.2=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath +org.glassfish.jersey.media:jersey-media-json-jackson:4.0.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath +org.glassfish.jersey:jersey-bom:4.0.2=compileClasspath,jarValidation,runtimeClasspath,runtimeLibs,testCompileClasspath,testRuntimeClasspath org.hamcrest:hamcrest:3.0=jarValidation,testCompileClasspath,testRuntimeClasspath org.javassist:javassist:3.30.2-GA=jarValidation,runtimeClasspath,runtimeLibs,testRuntimeClasspath org.jspecify:jspecify:1.0.0=annotationProcessor,apiHelper,compileClasspath,errorprone,jarValidation,runtimeClasspath,runtimeLibs,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath org.junit.jupiter:junit-jupiter-api:5.6.2=jarValidation,testCompileClasspath,testRuntimeClasspath org.junit.platform:junit-platform-commons:1.6.2=jarValidation,testCompileClasspath,testRuntimeClasspath -org.junit:junit-bom:5.13.4=compileOnlyHelper,compileOnlyHelperTest +org.junit:junit-bom:5.14.0=compileOnlyHelper,compileOnlyHelperTest org.junit:junit-bom:5.6.2=jarValidation,testCompileClasspath,testRuntimeClasspath Review Comment: The version catalog updates JUnit Jupiter to v6.0.3, but this lockfile still pins JUnit Jupiter/BOM to 5.6.2-era artifacts. With dependency locking enabled, this mismatch is likely to break dependency resolution (or prevent the intended upgrade). Regenerate/write lockfiles after updating versions (e.g., `--write-locks`) so the locked JUnit coordinates match the requested versions, and ensure only the intended JUnit BOM/Jupiter versions are locked for the relevant configurations. ########## changelog/unreleased/PR#3697-update-mockito.yml: ########## @@ -0,0 +1,7 @@ +title: Update mockito to v5.21.0 Review Comment: The version catalog/lockfiles in this PR upgrade Mockito to `5.23.0`, but this changelog entry still states `v5.21.0`. Update the changelog entry to reflect the actual version included by this PR. ```suggestion title: Update mockito to v5.23.0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
