dsmiley commented on code in PR #4314: URL: https://github.com/apache/solr/pull/4314#discussion_r3135057153
########## changelog/unreleased/SOLR-18181-ValueSourceAugmenter-npe.yml: ########## @@ -0,0 +1,7 @@ +title: Fix NPE in ValueSourceAugmenter when rows exceed prefetch limit with scores requested Review Comment: End users (who generally aren't Solr hackers) have no idea what ValueSourceAugmenter even is; it's an internal thing. They *do* know about use of function queries in the "fl". In the changelog we should try to explain the impact when we can, like: > Use of function queries in "fl" would fail if rows exceeds 1000 and scores requested. A regression since v9.9. Here, users would then see this for the serious regression that this is: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
