epugh commented on code in PR #4178:
URL: https://github.com/apache/solr/pull/4178#discussion_r3142391064
##########
solr/core/src/test/org/apache/solr/pkg/TestPackages.java:
##########
@@ -130,15 +130,14 @@ public void testCoreReloadingPlugin() throws Exception {
FILE1,
"L3q/qIGs4NaF6JiO0ZkMUFa88j0OmYc+I6O7BOdNuMct/xoZ4h73aZHZGc0+nmI1f/U3bOlMPINlSOM6LK3JpQ==");
- PackagePayload.AddVersion add = new PackagePayload.AddVersion();
+ AddPackageVersionRequestBody add = new AddPackageVersionRequestBody();
add.version = "1.0";
- add.pkg = "mypkg";
add.files = Arrays.asList(new String[] {FILE1});
V2Request req =
- new V2Request.Builder("/cluster/package")
+ new V2Request.Builder("/cluster/package/mypkg/versions")
Review Comment:
Originally I was trying to change as little as possible, but... It's so
much fun to erase `V2Request`, and I suspoose it also gvies us testing over the
generated code...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]