openworld-maker commented on PR #4216:
URL: https://github.com/apache/solr/pull/4216#issuecomment-4321626711
@dsmiley pushed follow-up updates:
- Addressed inline review points in `UpdateLog`:
- inlined replay span names
- removed redundant replay core attribute
- removed the extra outer `finally` and finalized replay-span attrs/end in
the existing `finally`
- switched URP chain tracing to `processorChain.toString()` and removed
custom summarizer
- Kept replay tracing test focused and removed the core-name assertion.
- Removed unrelated files from PR scope (`AGENTS.md`, `learnings.md`,
`RenameCoreAPITest`, `SolrTestCase` changes).
Validation run locally (Docker + JDK21):
- `:solr:core:compileJava`
- `:solr:core:test --tests org.apache.solr.update.UpdateLogReplayTracingTest`
- `tidy`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
