shubhamranjan commented on PR #4205:
URL: https://github.com/apache/solr/pull/4205#issuecomment-4321710256

   > How about fixing DirectoryFileStream.write() at point where it's adding 
extra packet? LocalFsFileStream.write() stops where bytesRead <= 0,
   > 
   > ```
   > long bytesRead = channel.read(bb);
   > if (bytesRead <= 0) {
   >     writeNothingAndFlush();
   >     // we close because DeflaterOutputStream requires a close call, but 
the request
   >     // outputstream is protected
   >     fos.close();
   >     break;
   > }
   > ```
   
   yeah, sounds like a better approach to fix at the sender side. Will 
refactor. Thank you ! 🙌 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to