kotman12 commented on PR #4279: URL: https://github.com/apache/solr/pull/4279#issuecomment-4330862852
> Thanks for the extra effort of modifying the test cases. This looks good to me. Please go ahead and merge whenever you can :) . I'd also recommend cherry picking to branch_10x and branch_9x please. @dsmiley is going to cut a 9.11 branch any time soon, so would be convenient to have this cherrypicked to branch_9x before that. I am also happy to help out and do this in case you are unable to get to this soon-ish(?). Just let me know. Thanks again for making this better! > Thanks for the extra effort of modifying the test cases. This looks good to me. Please go ahead and merge whenever you can :) . I'd also recommend cherry picking to branch_10x and branch_9x please. @dsmiley is going to cut a 9.11 branch any time soon, so would be convenient to have this cherrypicked to branch_9x before that. I am also happy to help out and do this in case you are unable to get to this soon-ish(?). Just let me know. Thanks again for making this better! Sure thing, thanks for taking a look! I will try to get to this tomorrow as I've been busy this past week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
