dsmiley commented on PR #3441: URL: https://github.com/apache/solr/pull/3441#issuecomment-4356411181
Coming back to this, I think this is close to what we should do. But I'd rather see the path extracted in the constructor so that QueryRequest no longer overrides getPath. Also the placement of these tests seems arbitrary/wrong to me, but the tests themselves are very good. Can you please create a new PR? If you are no longer interested, I'll maybe tell an AI agent to do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
