nicolo-rinaldi commented on code in PR #4375:
URL: https://github.com/apache/solr/pull/4375#discussion_r3189199052


##########
solr/modules/language-models/src/java/org/apache/solr/languagemodels/store/LanguageModelStore.java:
##########
@@ -14,53 +14,52 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-package org.apache.solr.languagemodels.textvectorisation.store;
+package org.apache.solr.languagemodels.store;
 
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
-import 
org.apache.solr.languagemodels.textvectorisation.model.SolrTextToVectorModel;
+import org.apache.solr.languagemodels.model.SolrLanguageModel;
 
-/** Simple store to manage CRUD operations on the {@link 
SolrTextToVectorModel} */
-public class TextToVectorModelStore {
+/** Generic store to manage CRUD operations on models that extend {@link 
SolrLanguageModel} */
+public class LanguageModelStore<M extends SolrLanguageModel> {

Review Comment:
   Renamed to `ModelT`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to