alessandrobenedetti commented on code in PR #4419:
URL: https://github.com/apache/solr/pull/4419#discussion_r3225725552
##########
gradle/libs.versions.toml:
##########
@@ -240,8 +240,8 @@ amazon-awssdk-s3 = { module = "software.amazon.awssdk:s3",
version.ref = "amazon
amazon-awssdk-sdkcore = { module = "software.amazon.awssdk:sdk-core",
version.ref = "amazon-awssdk" }
amazon-awssdk-sts = { module = "software.amazon.awssdk:sts", version.ref =
"amazon-awssdk" }
androidx-lifecycle-runtimeCompose = { module =
"org.jetbrains.androidx.lifecycle:lifecycle-runtime-compose", version.ref =
"androidx-lifecycle" }
-androidx-lifecycle-viewmodelCompose = { module =
"org.jetbrains.androidx.lifecycle:lifecycle-viewmodel-compose", version.ref =
"androidx-lifecycle" }
androidx-lifecycle-viewModelNav3 = { module =
"org.jetbrains.androidx.lifecycle:lifecycle-viewmodel-navigation3", version.ref
= "androidx-lifecycle" }
+androidx-lifecycle-viewmodelCompose = { module =
"org.jetbrains.androidx.lifecycle:lifecycle-viewmodel-compose", version.ref =
"androidx-lifecycle" }
Review Comment:
suspicious, probably a mistake?
##########
solr/solr-ref-guide/modules/query-guide/pages/text-to-vector.adoc:
##########
@@ -292,8 +292,6 @@
http://localhost:8983/solr/techproducts/schema/text-to-vector-model-store
----
-Documentation Indexing time
Review Comment:
was this originally a typo?
##########
solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestTextToVectorModelManager.java:
##########
@@ -127,7 +127,7 @@ public void testRestManagerEndpoints() throws Exception {
@Test
public void loadModel_cohere_shouldLoadModelConfig() throws Exception {
- loadModel("cohere-model.json");
+ loadTextToVectorModel("cohere-model.json");
Review Comment:
no need for the folder? is it ok to just mention the model name here?
##########
solr/modules/language-models/src/test/org/apache/solr/languagemodels/store/rest/TestTextToVectorModelManager.java:
##########
@@ -127,7 +127,7 @@ public void testRestManagerEndpoints() throws Exception {
@Test
public void loadModel_cohere_shouldLoadModelConfig() throws Exception {
- loadModel("cohere-model.json");
+ loadTextToVectorModel("cohere-model.json");
Review Comment:
no need for the folder? is it ok to just mention the model name here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
