[
https://issues.apache.org/jira/browse/SOLR-18188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18080296#comment-18080296
]
David Smiley commented on SOLR-18188:
-------------------------------------
I have a test run that just passed where no tests used anything in the "
org.apache.solr.client.solrj.apache" package. I anticipate some may be flaky –
need to run in SSL yet, maybe some timeout tuning. And then there's the
"nightlies" which I don't run by default, yet I need to run & fix them before
ultimately merging for sure. This is a branch continued from SOLR-17968. I
think my approach is to push a PR scoped to this branch minus the
HttpSolrClientBase related changes as that really needs the separate Jira it
already has. So it'll update tons of tests and some test-framework stuff,
albeit will leave some for later that kind of need the HttpSolrClientBase
refactoring to avoid a double-touch of the test. _Then_ finally, _after_
SOLR-17968, it can be ripped out completely, which will include minor SSL
related test updates.
> solr-test-framework: Remove Apache HttpClient usages
> ----------------------------------------------------
>
> Key: SOLR-18188
> URL: https://issues.apache.org/jira/browse/SOLR-18188
> Project: Solr
> Issue Type: Task
> Components: test-framework, Tests
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> As of this writing, the last usages of Apache HttpClient are in Solr's tests.
> This issue aims to remove it completely. But it's a lot of work.
> Some possible steps:
> * Remove tests for our HttpSolrClient & friends (fundamentally based on
> Apache HttpClient)
> * Replace usages of HttpSolrClient.getHttpClient with
> HttpJettySolrClient.getHttpClient
> * Replace usages of HttpSolrClient.getBaseURL by introducing a new base
> client that has this method. Or access similarly from Jetty when easily
> available.
> * of course, stop using HttpSolrClient & friends. Maybe class-by-class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
