mlbiscoc commented on code in PR #4284:
URL: https://github.com/apache/solr/pull/4284#discussion_r3227151472
##########
solr/core/src/java/org/apache/solr/core/ZkContainer.java:
##########
@@ -176,44 +176,44 @@ public void initializeMetrics(
});
ctx.observableLongCounter(
- "solr_zk_read",
+ "solr.zk.read",
"Total bytes read from ZooKeeper",
measurement -> {
measurement.record(metricsListener.getBytesRead(),
attributes);
},
OtelUnit.BYTES);
ctx.observableLongCounter(
- "solr_zk_watches_fired",
+ "solr.zk.watches_fired",
"Total number of ZooKeeper watches fired",
measurement -> {
measurement.record(metricsListener.getWatchesFired(),
attributes);
});
ctx.observableLongCounter(
- "solr_zk_written",
+ "solr.zk.written",
"Total bytes written to ZooKeeper",
measurement -> {
measurement.record(metricsListener.getBytesWritten(),
attributes);
},
OtelUnit.BYTES);
ctx.observableLongCounter(
- "solr_zk_cumulative_multi_ops_total",
+ "solr.zk.cumulative.multi_ops.total",
"Total cumulative multi-operations count",
measurement -> {
measurement.record(metricsListener.getCumulativeMultiOps(), attributes);
});
ctx.observableLongCounter(
- "solr_zk_child_fetches",
+ "solr.zk.child.fetches",
"Total number of ZooKeeper child node fetches",
measurement -> {
measurement.record(metricsListener.getChildFetches(),
attributes);
});
Review Comment:
Yes lets avoid `child.fetches` but also this name entirely. It should
probably be `solr.zk.get_children.ops` as `get_children` is the actual curator
operation method name. Basically what I say here:
> WDYT of solr_zk_child_fetches -> solr.zk.get_children.ops and
solr_zk_cumulative_children_fetched -> solr.zk.children.fetched? But then also
would someone even care about the total number of solr.zk.children_fetched from
a Solr perspective? I would probably just drop that metric now that I think of
it but idk maybe someone thinks otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
