[
https://issues.apache.org/jira/browse/SOLR-17810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18080997#comment-18080997
]
David Smiley commented on SOLR-17810:
-------------------------------------
I'll have to ignore the test soon, since the test fails when the Jetty
HttpClient is used. I've been working on migrating completely away from Apache
HttpClient.
It'd be straight-forward for me to tell a GitHub CoPilot Agent to address the
header issue. I think in the PR I recommended basically putting this header in
the SolrRequest by default. But it's fine to do this in both clients as
well... albeit I think you could have placed them slightly better (I'm being
picky) than where you put each line of code previously.
> RateLimiting doesn't work for non-Apache Http SolrClients
> ---------------------------------------------------------
>
> Key: SOLR-17810
> URL: https://issues.apache.org/jira/browse/SOLR-17810
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: David Smiley
> Priority: Critical
> Labels: newdev, pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Solr's rate limiting SOLR-13528 needs to know the request type to do its job.
> This is passed as a HTTP header, but at present only the deprecated
> HttpSolrClient is doing this. The others should too! See this comment Just
> now.
> All we have to do is ensure that the Jetty & JDK based HTTP SolrClients pass
> on an HTTP header, just like the Apache one does. Hopefully this can happen
> in their base class.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
