epugh commented on PR #4427: URL: https://github.com/apache/solr/pull/4427#issuecomment-4460188942
This all looks good to me, and I'm inclined to merge it when I get a good tests run. The only thing I wonder about, and this is my lack of overall knowledge, is that while we are fixing the NPE, is there any chance that the fact that you can get an NPE implies a bug or issue furthur up the process? How does a field come in that has a null value? Is that acceptable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
