[ 
https://issues.apache.org/jira/browse/SOLR-18242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18081383#comment-18081383
 ] 

ASF subversion and git services commented on SOLR-18242:
--------------------------------------------------------

Commit 680011d0171273824358fdb0b53b5187f5ebeb62 in solr's branch 
refs/heads/branch_10x from Jalaz Kumar
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=680011d0171 ]

SOLR-18242: DistribFileStore: refactor, don't use SolrClientCache (#4428)

SolrClientCache is only needed to pool CloudSolrClient (different clusters)

(cherry picked from commit 336205f44759c24ca9ab18743579cb7f6ec6cbd5)


> Refactor: SolrClientCache shouldn't be used by DistribFileStore
> ---------------------------------------------------------------
>
>                 Key: SOLR-18242
>                 URL: https://issues.apache.org/jira/browse/SOLR-18242
>             Project: Solr
>          Issue Type: Task
>            Reporter: David Smiley
>            Priority: Major
>              Labels: newdev, pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The DistribFileStore shouldn't be using the SolrClientCache.  it should 
> simply use CoreContainer.getDefaultHttpSolrClient where it can call 
> request.processWithBaseUrl using that client.
> The overarching theme is to reduce SolrClientCache to only where it's truly 
> needed, and this spot certainly doesn't warrant it.  Furthermore this is the 
> only caller of SolrClientCache.getHttpSolrClient outside of solrj-streaming, 
> and I'm looking to remove that method altogether eventually.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to