[
https://issues.apache.org/jira/browse/SOLR-17968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18081564#comment-18081564
]
ASF subversion and git services commented on SOLR-17968:
--------------------------------------------------------
Commit 8d3f995c6ac1633be0850d7715b788f9876ca4f2 in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=8d3f995c6ac ]
SOLR-17968: HttpSolrClient as new base class (#3829)
**Summary:** Reintroduce HttpSolrClient by promoting and refactoring
`HttpSolrClientBase`. Kept the(test) Apache HttpClient implementation in its
own package while new Jetty and JDK implementations extend the common base.
**Key Changes:**
1. **Renamed** `HttpSolrClientBase` → `HttpSolrClient` (new primary base class)
2. **Restructured builders** - converted `HttpSolrClientBuilderBase` into an
inner class `HttpSolrClient.BuilderBase`
3. **Added factory method** - static `HttpSolrClient.builder(url)` to simplify
client creation
4. **Method rename** - instance method `builder()` → `toBuilder(url)` to avoid
naming conflicts
> Add HttpSolrClient as base class
> --------------------------------
>
> Key: SOLR-17968
> URL: https://issues.apache.org/jira/browse/SOLR-17968
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Affects Versions: 10.0
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Add HttpSolrClient base class with {{{}getBaseURL(){}}}. HttpSolrClientBase
> (base of Jetty & JDK clients) shall implement it.
> The "old" HttpSolrClient (the implementation using Apache HttpClient) is
> temporarily in the test framework on death row. This issue would rename that
> to HttpApacheSolrClient, and also make it extend HttpSolrClient. There's a
> bit of builder conversion to do, to make that happen there.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
