dsmiley commented on code in PR #4429:
URL: https://github.com/apache/solr/pull/4429#discussion_r3262157850
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedQueryComponentOptimizationTest.java:
##########
Review Comment:
```suggestion
// Create a collection on only node 0; node 1 will use LazyCollectionRef
for state
```
Clarifying the node numbers rather than generally referring to a
single/other node. Definitely wasn't wrong but now it jives with get(0) vs
get(1).
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedQueryComponentOptimizationTest.java:
##########
@@ -724,7 +724,12 @@ public void testDistributedQueryDoesNotReadFromZk() throws
Exception {
CollectionAdminRequest.createCollection(secondColl, "conf", 1, 1)
.setCreateNodeSet(jettys.get(0).getNodeName())
.processAndWait(cluster.getSolrClient(), DEFAULT_TIMEOUT);
- cluster
+
+ // Wait on node 1's ZkStateReader (not the cluster client's) to check for
ready state
+ JettySolrRunner nodeWithoutSecondColl = jettys.get(1);
Review Comment:
I love this var name. Maybe node 0 should have a similar var name we can
use like "nodeWithBothColls". Just an idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
