epugh commented on PR #4185: URL: https://github.com/apache/solr/pull/4185#issuecomment-4488791249
> > We have a class called `EnvUtils` that I think handles a lot of this... Can you shed any light on if there is something about the cross dc stuff that prevents us from using `EnvUtils`? > > We should use it - I believe the reason was that the original crossdc contribution was developed a long time ago in the sandbox, before the introduction of EnvUtils, and then never refactored. Thanks for confirming the EnvUtils use. Any thing else on this PR jump out to you @sigram ? I'm hoping @gsingh-code will get tests to pass or confirm they are just flaky ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
