Copilot commented on code in PR #18: URL: https://github.com/apache/solr-orbit/pull/18#discussion_r3293587542
########## DEVELOPER_GUIDE.md: ########## @@ -15,7 +15,7 @@ Apache Solr Orbit. ## Prerequisites -- **Python 3.9+**: Use [pyenv](https://github.com/pyenv/pyenv) to manage +- **Python 3.12+**: Use [pyenv](https://github.com/pyenv/pyenv) to manage Python versions. Review Comment: PR description says the macOS 15 / Python 3.10-3.11 hang is documented in DEVELOPER_GUIDE.md, but this section only bumps the prerequisite version and does not mention the macOS 15 incompatibility/rationale. Either add the promised note here (and/or link to the issue) or adjust the PR description to match what the code/docs actually change. ########## Makefile: ########## @@ -29,14 +29,14 @@ pyinst: @for i in $(VERSIONS); do pyenv install --skip-existing $$i; done pyenv local $(VERSIONS) -pyinst310: +pyinst312: @which pyenv > /dev/null 2>&1 || { printf $(PYENV_ERROR); exit 1; } - pyenv install --skip-existing $(VERSION310) - pyenv local $(VERSION310) + pyenv install --skip-existing $(VERSION312) + pyenv local $(VERSION312) check-pip: # Install pyenv if the Python environment is externally managed. - @if ! $(PIP) > /dev/null 2>&1 || ! $(PIP) install pip > /dev/null 2>&1; then make pyinst310; fi + @if ! $(PIP) > /dev/null 2>&1 || ! $(PIP) install pip > /dev/null 2>&1; then make pyinst312; fi Review Comment: This PR updates the minimum Python version targets (pyinst312/check-pip), but PYTHON_SUPPORT_GUIDE.md still contains 3.10-specific examples (VERSION310/pyinst310/check-pip and the minimum-version error message example). Update that guide to reflect the new 3.12+ baseline so future version bumps follow the correct pattern. ########## osbenchmark/__init__.py: ########## @@ -83,8 +83,8 @@ def check_python_version(): - if sys.version_info < (3, 10): - raise RuntimeError("solr-orbit requires at least Python 3.10 but you are using:\n\nPython %s" % str(sys.version)) + if sys.version_info < (3, 12): + raise RuntimeError("solr-benchmark requires at least Python 3.12 but you are using:\n\nPython %s" % str(sys.version)) Review Comment: The raised RuntimeError message uses "solr-benchmark" even though the package name, console scripts, and banner refer to "solr-orbit". This will confuse users hitting the version gate; update the message to consistently reference Solr Orbit (and keep capitalization consistent with other docs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
