vyatkinv commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3312413703
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamExpression.java:
##########
@@ -76,6 +78,14 @@ public void setParameters(List<StreamExpressionParameter>
parameters) {
this.parameters = parameters;
}
+ public void addParameters(SolrParams parameters) {
Review Comment:
This method should be called `withParameters`, but this name is taken by the
method below, which overwrites existing parameters. That's why I chose the name
`addParameters` to avoid confusion, because behaviour of my method different
from `withParameters`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
