epugh commented on code in PR #4320: URL: https://github.com/apache/solr/pull/4320#discussion_r3328828924
########## solr/packaging/test/test_zk.bats: ########## Review Comment: if you pass in a solr-connection, then it figures out the zk connection by first connecting to Solr, then internally it gets the zk connection string, and then in turn uses that. Now, if instead you pass in `-z`, then you don't go to the Solr node. The idea being that you can use the `solr zk` commands without knowing about the specific ZooKeeper details. This may also be really useful if we start seeing more folks encrypt traffic between ZooKeeper and Solr, and then you woulnd' tneed all those details locally to connect. Just connect to Solr using your standard permissions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
