janhoy commented on code in PR #4495:
URL: https://github.com/apache/solr/pull/4495#discussion_r3340782966
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedCombinedQueryComponentTest.java:
##########
@@ -228,38 +207,22 @@ public void testHybridQueryWithPagination() throws
Exception {
"/search");
assertEquals(4, rsp.getResults().size());
assertFieldValues(rsp.getResults(), id, "6", "3", "10", "4");
- }
- /**
- * Tests the single query functionality with faceting only.
- *
- * @throws Exception if any unexpected error occurs during the test
execution.
- */
- @Test
- public void testQueryWithFaceting() throws Exception {
- prepareIndexDocs();
- String jsonQuery =
+ // faceting
+ String facetQuery =
"{\"queries\":"
+ "{\"lexical\":{\"lucene\":{\"query\":\"id:(2^2 OR 3^1 OR 6^2 OR
5^1)\"}}},"
+ "\"limit\":3,\"offset\":1"
Review Comment:
Did a conversion to `"""` string block for all JSON strings, making it more
readable and also catching another missing comma in `facetQuery` string. Lifted
unnamed inline JSON out into String variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
