alessandrobenedetti commented on code in PR #4492:
URL: https://github.com/apache/solr/pull/4492#discussion_r3347693109
##########
solr/core/src/test-files/solr/collection1/conf/bad-schema-densevector-flat-bq.xml:
##########
Review Comment:
let's be explciit in the names where possible:
bq=binaryQuantized
##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -471,6 +473,9 @@ public DenseVectorParser getVectorBuilder(
}
public KnnVectorsFormat buildKnnVectorsFormat() {
+ if (FLAT_ALGORITHM.equals(knnAlgorithm)) {
+ return new SolrFlatVectorFormat();
+ }
Review Comment:
Probably better readability with if else
##########
solr/core/src/test-files/solr/collection1/conf/bad-schema-densevector-flat-sq.xml:
##########
Review Comment:
same here, scalar quantized
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
