janhoy commented on code in PR #4497:
URL: https://github.com/apache/solr/pull/4497#discussion_r3351003135
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedCombinedQueryComponentTest.java:
##########
@@ -170,15 +176,21 @@ public void testMultipleLexicalQuery() throws Exception {
* @throws Exception the exception
*/
@Test
+ @ShardsFixed(num = 2)
public void testMultipleQueryWithSort() throws Exception {
prepareIndexDocs();
String jsonQuery =
- "{\"queries\":"
- + "{\"lexical1\":{\"lucene\":{\"query\":\"id:(2^2 OR 3^1 OR 6^2 OR
5^1)\"}},"
- + "\"lexical2\":{\"lucene\":{\"query\":\"id:(4^1 OR 5^2 OR 7^3 OR
10^2)\"}}},"
- + "\"limit\":5,\"sort\":\"mod3_idv desc, score desc\""
Review Comment:
Note, this line was missing a comma at the end
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedCombinedQueryComponentTest.java:
##########
@@ -236,15 +253,26 @@ public void testHybridQueryWithPagination() throws
Exception {
* @throws Exception if any unexpected error occurs during the test
execution.
*/
@Test
+ @ShardsFixed(num = 2)
public void testQueryWithFaceting() throws Exception {
prepareIndexDocs();
String jsonQuery =
- "{\"queries\":"
- + "{\"lexical\":{\"lucene\":{\"query\":\"id:(2^2 OR 3^1 OR 6^2 OR
5^1)\"}}},"
- + "\"limit\":3,\"offset\":1"
Review Comment:
This line was missing a comma...
##########
solr/core/src/test/org/apache/solr/handler/component/DistributedCombinedQueryComponentTest.java:
##########
@@ -60,9 +60,8 @@ public static void setUpClass() {
*
* @throws Exception if any error occurs during the indexing process.
*/
- private synchronized void prepareIndexDocs() throws Exception {
+ private void prepareIndexDocs() throws Exception {
List<SolrInputDocument> docs = new ArrayList<>();
- fixShardCount(2);
Review Comment:
This was causing the infinite hang in nightly tests, see description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
