adityamparikh opened a new pull request, #139:
URL: https://github.com/apache/solr-mcp/pull/139
## Summary
- The three Docker integration tests in
`src/test/java/org/apache/solr/mcp/server/containerization/` built
`DOCKER_IMAGE` as `BuildInfoReader.getDockerImageName() +
System.getProperty("solr.mcp.docker.image.tag.suffix", "")`, but
`BuildInfoReader.getDockerImageName()` already honors that same system property
internally. The suffix was therefore applied twice — e.g.
`solr-mcp:1.0.0-SNAPSHOT-native-stdio-native-stdio` — and the local Docker
daemon 404'd on the pull.
- `DockerImageMcpClientStdioIntegrationTest` showed the same root cause as a
20-second `initialize()` timeout: its `docker run` subprocess exited
immediately (no such tag) before any JSON-RPC `initialize` could be sent.
- Fix: drop the caller-side concatenation in all three tests so the tag
matches what Paketo actually produced.
## Test plan
- [x] `./gradlew spotlessApply build` green locally
- [ ] `./gradlew dockerIntegrationTest -Pnative` succeeds (native-stdio
variant) — needs committer-approved CI run on the fork PR
- [ ] `./gradlew dockerIntegrationTest -Pnative -Pprofile=http` succeeds
(native-http variant)
- [ ] `./gradlew dockerIntegrationTest` (Jib JVM) still green
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
