janhoy commented on PR #4499: URL: https://github.com/apache/solr/pull/4499#issuecomment-4629149114
> I forgot if Lucene has moved onto a newer RAT release that addresses this natively. Lucene moved away from RAT to a custom build-src java class, see https://github.com/apache/lucene/pull/15195. Also, we could upgrade RAT, as a newer version includes tracked file handling as a native feature, but not the way we hold it - we use the Ant task programatically. If RAT only would publish a gradle plugin, not just a maven one. ### This PR now - Replace shell-out with JGit: Use JGit's DirCache API (already a build dependency) instead of shelling out to `git ls-files --cached` to determine tracked files - Read the git index once and cache it via rootProject.ext, avoiding redundant I/O across ~40 subproject rat tasks - Detect git worktrees (.git is a file) with a clear warning, handle non-git directories by disabling the filter (RAT scans everything as before), and use finally to prevent repository resource leaks - Normalize path separators (\ → /) when computing subproject prefixes, since JGit always uses forward slashes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
