janhoy commented on code in PR #138: URL: https://github.com/apache/solr-mcp/pull/138#discussion_r3361858982
########## NOTICE: ########## @@ -0,0 +1,5 @@ +Apache Solr MCP Server +Copyright 2026 The Apache Software Foundation + +This product includes software developed at Review Comment: Answering my own question. As per https://infra.apache.org/licensing-howto.html the current `LICENSE` and `NOTICE` files are correct for the source-release artifact. But the `LICENSE` file for the binary release (fat-jar or tgz) must reference all non-apache licenses used by all dependencies. Not a full license-text copy but a link to the full license. And the `NOTICE` file embedded in binary release must lift relevant NOTICE snippets from the Apache-licensed dependencies, notably other ASF project dependencies. Thus we need some tooling to assemble LICENSE/NOTICE for the binary distro. A common way of doing it is to check in a `licenses/` folder with necessary files, and wire some check task into the build to verify that newly added deps are mentioned. Solr does a rigid version of this with separate files in licenses/ for every dependency, even test-deps. That should not be necessary. And the Solr main dist does not currenty use different LICENSE/NOTICE files for src and binary distros, this is a bug and has an open JIRA. The Solr repo also mistakenly adds too much stuff in NOTICE, stuff which shuold have beed appended to LICENSE intead. Well well... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
