gerlowskija commented on code in PR #4370:
URL: https://github.com/apache/solr/pull/4370#discussion_r3390864291
##########
solr/core/src/test/org/apache/solr/jersey/PostRequestLoggingFilterTest.java:
##########
@@ -96,6 +103,42 @@ public void
testBuildQueryParameterString_ExcludesFilteredParameters() {
assertEquals("paramName1=paramValue1¶mName2=paramValue2",
queryParamStr);
}
+ @Test
+ @SuppressWarnings("unchecked")
+ public void
testCachingJsonMessageBodyReaderDelegateUsesConfiguredObjectMapper()
Review Comment:
[0] It'd be great to have a code comment at the top of this test that
clarifies how it proves that the expected mapper is used. IMO it'll be hard
for anyone stumbling on this outside the context of this PR to get what's going
on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
