gerlowskija commented on code in PR #4240:
URL: https://github.com/apache/solr/pull/4240#discussion_r3395499347
##########
solr/api/src/java/org/apache/solr/client/api/endpoint/NodeSystemInfoApi.java:
##########
@@ -31,4 +33,18 @@ public interface NodeSystemInfoApi {
summary = "Retrieve all node system info.",
tags = {"system"})
NodeSystemResponse getNodeSystemInfo(@QueryParam(value = "nodes") String
nodes);
+
+ @GET
+ @Operation(
+ summary = "Retrieve specific node system info.",
+ tags = {"system"},
+ parameters = {
+ @Parameter(
+ name = "requestedInfo",
+ description = "Allowed values: 'gpu', 'jvm', 'lucene', 'security',
'system'")
+ })
+ @Path("/{requestedInfo}")
+ NodeSystemResponse getSpecificNodeSystemInfo(
+ @PathParam(value = "requestedInfo") String requestedInfo,
Review Comment:
Turns out we can! This "just kindof worked" when I tried switching it over.
I've pushed the changes to your branch - if you don't like the change just lmk
and I'm happy to roll it back.
There are a bunch of other places (mostly marked by TODOs in the `api/`
module) where I've thought about using an enum in these API definitions but
didn't quite have time to check if that'd work. Should tackle these in a
follow-on PR....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
