isaric commented on PR #4465: URL: https://github.com/apache/solr/pull/4465#issuecomment-4684459219
Rebased onto current main (which now contains parts 1 and 2) and force-pushed (`c256eb180d4`). The branch is now a single self-contained commit covering only the SolrJ / utilities migration — removing `MapWriter`'s `MapSerializable` inheritance and the `toMap` default, plus the matching adjustments in `JavaBinCodec`, `TextWriter`, `Utils`, `IteratorWriter`, `ZkNodeProps`, the streaming Explanation classes, and the extraction module. Regression check before pushing (all green): - `TestPackages`, `TestSolrConfigHandler`, `TestConfig`, `CacheConfigTest`, `SolrIndexConfigTest`, `NodeConfigClusterPluginsSourceTest`, `TestSchemaDesignerAPI`, `TestDistribFileStore`, `TestZookeeperInfoHandler` - `TestUtils`, `TestJavaBinCodec`, `TestZkNodeProps` Grepped for any remaining `.toMap(...)` calls on `MapWriter`-typed receivers in production code — none. Ready for your review. Taking the lesson from your retrospective comment for any future stacks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
