Copilot commented on code in PR #4524: URL: https://github.com/apache/solr/pull/4524#discussion_r3408028529
########## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ########## @@ -226,6 +226,8 @@ Attention: * `OpenTracing` libraries were removed and replaced with `OpenTelemetry` libraries. Any Java agents providing `OpenTracing` tracers will no longer work. Telemetry tags `http.status_code` and `http.method` have been deprecated, newer versions of the tags have been added to the span data: `http.response.status_code`, `http.request.method`. +* The deprecated telemetry tags `http.status_code` and `http.method` have been removed from span data. Use `http.response.status_code` and `http.request.method` instead. (SOLR-18110) + Review Comment: The two consecutive bullets are a bit contradictory/ambiguous: one says `http.status_code`/`http.method` "have been deprecated" (which can read as still present), while the next says they have been removed. Since this is Solr 10 major changes, it would be clearer to state they are removed (or to consolidate into a single bullet). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
