utsav00 commented on PR #4525: URL: https://github.com/apache/solr/pull/4525#issuecomment-4698689441
> LGTM. Having said that, it feels like there should be more of a pointer to the fix, but this also seems so down in the weeds that maybe that doesn't matter. Sigh, ignore my angst. Haha, I get it. I followed the 9.x convention. And did add a reference of what to use in its stead in the changelog and guide. Can also add a xref to the 9.x note but I think it's minor. Lmk if you were thinking in another direction > I triggered the run, and assuming it passes will merge. Thank you 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
