Copilot commented on code in PR #146:
URL: https://github.com/apache/solr-mcp/pull/146#discussion_r3408379794
##########
src/main/java/org/apache/solr/mcp/server/schema/SchemaService.java:
##########
@@ -310,6 +324,21 @@ public SchemaUpdateResult
addFields(@McpToolParam(description = "Solr collection
return new SchemaUpdateResult(collection, names);
}
+ /**
+ * Adds one or more field types to a Solr collection schema as a single
+ * transactional batch.
+ *
+ * @param collection
+ * target Solr collection name
+ * @param fieldTypes
+ * field-type definitions in the Solr Schema API
+ * {@code add-field-type} shape
+ * @return summary listing the collection and the names of the field
types added
+ * @throws SolrServerException
+ * if there are if there are errors communicating with Solr
Review Comment:
Javadoc typo: duplicated phrase "if there are" in the `@throws` description.
##########
src/main/java/org/apache/solr/mcp/server/schema/SchemaService.java:
##########
@@ -278,6 +278,20 @@ public SchemaRepresentation getSchema(String collection)
throws Exception {
return schemaRequest.process(solrClient,
collection).getSchemaRepresentation();
}
+ /**
+ * Adds one or more fields to a Solr collection schema as a single
transactional
+ * batch.
+ *
+ * @param collection
+ * target Solr collection name
+ * @param fields
+ * field definitions in the Solr Schema API {@code
add-field} shape
+ * @return summary listing the collection and the names of the fields
added
+ * @throws SolrServerException
+ * if there are if there are errors communicating with Solr
Review Comment:
Javadoc typo: duplicated phrase "if there are" in the `@throws` description.
##########
src/main/java/org/apache/solr/mcp/server/Main.java:
##########
@@ -105,6 +105,11 @@
*/
@SpringBootApplication
public class Main {
+
+ /** Default constructor used by Spring Boot to bootstrap the
application. */
+ public Main() {
+ }
+
static void main(String[] args) {
Review Comment:
The application entry point must be a `public static void main(String[]
args)` method. As written, the method is package-private, which can prevent the
JVM/launcher (and Gradle/Spring Boot packaging) from starting the app.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
