Copilot commented on code in PR #147:
URL: https://github.com/apache/solr-mcp/pull/147#discussion_r3408414346
##########
README.md:
##########
@@ -35,7 +41,7 @@ A Spring AI Model Context Protocol (MCP) server that provides
tools for interact
```
- Docker:
```bash
- docker run -i --rm ghcr.io/apache/solr-mcp:latest
+ docker run -i --rm solr-mcp:latest
Review Comment:
This Docker run command will use the default `SOLR_URL` of
`http://localhost:8983/solr/`, which points to the container itself (not the
Solr instance started via `docker compose up -d`). Make the quick-start command
explicitly point at the host Solr port (and add the Linux host-gateway mapping
used in tests).
##########
README.md:
##########
@@ -13,11 +13,17 @@ A Spring AI Model Context Protocol (MCP) server that
provides tools for interact
- 🔧 Inspect schema
- 🔌 Transports: STDIO (Claude Desktop) and HTTP (MCP Inspector)
- 🔐 OAuth2 security with Auth0 (HTTP mode only)
-- 🐳 Docker images built with Jib
+- 🐳 Docker images built locally with Jib (JVM) and Paketo (native)
## Get started (users)
+> **Note:** Published container images are not yet available on a public
registry. The `docker run` examples below use a **locally built** image — build
it first with `./gradlew jibDockerBuild` (produces `solr-mcp:latest`), or use
the JAR path instead. See [Building Docker images](#building-docker-images).
Review Comment:
This note claims published container images are not available on a public
registry, but the repo contains workflows/docs that publish images to
registries (e.g., `.github/workflows/build-and-publish.yml` pushes to GHCR). To
avoid conflicting documentation, rephrase the note to only state that the
examples assume a locally available image and how to build it.
##########
README.md:
##########
@@ -48,7 +54,7 @@ A Spring AI Model Context Protocol (MCP) server that provides
tools for interact
```
- Docker:
```bash
- docker run -p 8080:8080 --rm -e PROFILES=http
ghcr.io/apache/solr-mcp:latest
+ docker run -p 8080:8080 --rm -e PROFILES=http solr-mcp:latest
Review Comment:
Same issue as the STDIO Docker command above: without `SOLR_URL`, the
container will try `http://localhost:8983/solr/` (inside the container) and
won't reach the Solr instance started by `docker compose up -d`. Include
`SOLR_URL` (and the Linux host-gateway mapping used in tests) in this example.
##########
README.md:
##########
@@ -187,7 +193,7 @@ Add Solr MCP to [Claude
Code](https://docs.anthropic.com/en/docs/claude-code) us
Using Docker (CLI):
```bash
-claude mcp add --transport stdio solr-mcp -- docker run -i --rm
ghcr.io/apache/solr-mcp:latest
+claude mcp add --transport stdio solr-mcp -- docker run -i --rm solr-mcp:latest
Review Comment:
This `claude mcp add` Docker example doesn't pass `SOLR_URL`, so the
container will default to `http://localhost:8983/solr/` (inside the container)
and fail to reach Solr started on the host via Docker Compose. Pass `SOLR_URL`
(and the Linux host-gateway mapping used in tests) directly to `docker run`.
##########
dev-docs/DEVELOPMENT.md:
##########
@@ -37,6 +37,37 @@ The build produces an executable JAR in `build/libs/`:
- `solr-mcp-1.0.0-SNAPSHOT.jar` — Spring Boot executable (fat) JAR
+### Publishing to Maven Local
+
+To install the project artifacts to your local Maven repository for testing or
local development:
+
+```bash
+./gradlew publishToMavenLocal
+```
+
+This publishes the following artifacts to
`~/.m2/repository/org/apache/solr/solr-mcp/{version}/`:
+
+- `solr-mcp-{version}.jar` - Main application JAR
+- `solr-mcp-{version}-sources.jar` - Source code for IDE navigation
+- `solr-mcp-{version}-javadoc.jar` - API documentation
+- `solr-mcp-{version}.pom` - Maven POM with dependencies
+
+This is useful when:
+- Testing the library locally before publishing to a remote repository
+- Sharing artifacts between local projects during development
Review Comment:
This section describes publishing an application artifact, but the first
bullet says “Testing the library locally…”, which is inconsistent with the
surrounding wording (“Main application JAR”) and may mislead readers about what
is being published. Use “artifacts” (or “application”) consistently.
##########
README.md:
##########
@@ -240,7 +246,7 @@ PROFILES=http ./gradlew bootRun
PROFILES=http java -jar build/libs/solr-mcp-1.0.0-SNAPSHOT.jar
# Docker
-docker run -p 8080:8080 --rm -e PROFILES=http ghcr.io/apache/solr-mcp:latest
+docker run -p 8080:8080 --rm -e PROFILES=http solr-mcp:latest
Review Comment:
This HTTP-mode Docker example starts the container without `SOLR_URL`, so it
will default to `http://localhost:8983/solr/` inside the container and
typically won't reach Solr on the host. Include `SOLR_URL` (and the Linux
host-gateway mapping used in tests).
##########
README.md:
##########
@@ -158,7 +164,7 @@ PROFILES=http java -jar
build/libs/solr-mcp-1.0.0-SNAPSHOT.jar
Running via Docker:
```bash
-docker run -p 8080:8080 --rm -e PROFILES=http ghcr.io/apache/solr-mcp:latest
+docker run -p 8080:8080 --rm -e PROFILES=http solr-mcp:latest
Review Comment:
This Docker command starts the server without setting `SOLR_URL`, so it will
default to `http://localhost:8983/solr/` inside the container and typically
won't reach Solr running on the host. Update the example to pass `SOLR_URL`
(and the Linux host-gateway mapping used in tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
