janhoy commented on code in PR #4534:
URL: https://github.com/apache/solr/pull/4534#discussion_r3433894658
##########
solr/webapp/web/js/angular/controllers/security.js:
##########
@@ -412,6 +412,12 @@ solrAdminApp.controller('SecurityController', function
($scope, $timeout, $cooki
return false;
}
+ var username = $scope.upsertUser.username ?
$scope.upsertUser.username.trim() : "";
+ if (password === username) {
+ $scope.validationError = "Password must not be the same as the username";
+ return false;
+ }
Review Comment:
You could argue that `SecurityConfHandler`'s lack of proper error handling,
and the security UI's lack of catching those, could have been a separate PR.
But they are highly related. If anyone wants me to rip those out into their own
PR I can do so, but I'd nedd to find another failure situation for the tests..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
