renatoh commented on code in PR #4406:
URL: https://github.com/apache/solr/pull/4406#discussion_r3444181095
##########
solr/core/src/java/org/apache/solr/search/BoolQParserPlugin.java:
##########
@@ -46,10 +48,12 @@ public Query parse() throws SyntaxError {
}
@Override
- protected BooleanQuery.Builder createBuilder() {
- BooleanQuery.Builder builder = super.createBuilder();
- builder.setMinimumNumberShouldMatch(localParams.getInt("mm", 0));
- return builder;
+ protected BooleanQuery parseImpl() throws SyntaxError {
+ BooleanQuery query = super.parseImpl();
+ SolrParams solrParams = SolrParams.wrapDefaults(localParams, params);
Review Comment:
I see you point, I think we can easily fix it by just doing:
SolrPluginUtils.parseMinShouldMatch(req.getSchema(), localParams);
and not calling SolrPluginUtils.parseMinShouldMatch(req.getSchema(),
localParams);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
