Copilot commented on code in PR #4555: URL: https://github.com/apache/solr/pull/4555#discussion_r3486613452
########## versions.props: ########## @@ -58,6 +58,8 @@ org.apache.kafka:*=3.9.2 org.apache.kerby:*=2.1.0 org.apache.logging.log4j:*=2.26.0 org.apache.lucene:*=9.12.3 +# Override transitive opennlp-tools version from Lucene to use a newer release +org.apache.opennlp:opennlp-tools=1.9.5 Review Comment: The new override is fine, but the comment is a bit misleading: `opennlp-tools` is also declared as a direct dependency (e.g., analysis-extras/langid), so this is more accurately an override of the version Solr would otherwise inherit from Lucene. Also, the ref-guide template still hardcodes `dep-version-opennlp: '1.9.4'` (solr/solr-ref-guide/antora.yml:53) and there are module comments claiming opennlp isn't defined in versions.props—those should be updated in the same PR to avoid stale documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
