janhoy commented on PR #3119:
URL: https://github.com/apache/solr/pull/3119#issuecomment-4847942433
### Triage status — what's blocking this bump
I dug into the failing CI on this PR. Summary for whoever picks it up:
**Versions are current.** `calcite-core 1.42.0` and `avatica-core 1.28.0`
are both the latest on Maven Central. The `sql` module **compiles cleanly**
against 1.42 — no source API breakage.
**1. `gradle check` failure = missing license files (easy).**
calcite 1.42 pulls a *new* transitive dependency
`org.jooq:joou-java-6:0.9.4` (via `avatica-core`), so
`:solr:modules:sql:validateJarLicenses` fails. Fix = add the two missing files:
- `solr/licenses/joou-java-6-LICENSE-ASL.txt` (joou is Apache-2.0; text is
bundled in the jar's `META-INF/LICENSE.txt`)
- `solr/licenses/joou-java-6-NOTICE.txt`
After adding those, `validateJarLicenses` passes project-wide.
> Note: `joou` is actually **unused** (0 bytecode references in avatica-core
/ calcite-core / linq4j — avatica just over-declares it in its POM). It *could*
be excluded, but it leaks back through the `:platform` consistent-resolution +
dependency-locking machinery, so a clean exclude needs more than a one-line
change. Adding the license files is the low-risk path.
**2. Real test regressions (the actual blocker).**
`TestSQLHandler` has ~5 failures caused by calcite 1.42 / avatica 1.28
*behavioral* changes — these need code work in the SQL-handler calcite
integration, not just a version bump:
- **TIMESTAMP/date literals**: `WHERE pdatex >= CAST('…' as TIMESTAMP)` and
`WHERE pdatex = '2021-06-04 04:00:00'` now error.
- **DISTINCT projection returns null**: `expected:<a> but was:<null>` (×3).
- **`score is not a valid field for unlimited queries`**: the planner now
injects `score` into the export field list.
So this PR is **not mergeable as-is** — it needs the license files plus
fixes for the planner/coercion regressions above. Parking it for now in favor
of more tractable dependency upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
